Storyline page: 3-col stats boxes like profile page#805
Conversation
Replace the separate market stats section with 3 bordered stat boxes (Market Cap, Supply Minted, Deadline) matching the profile page box style. On desktop, boxes sit inside the info panel next to the Moleskine cover. On mobile, they stack as a 3-col grid below the info rows. Fixes #802 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The layout move itself is in the right area, but the final render does not actually produce three matching stat boxes. One box keeps the old label/value ordering while the new boxes invert it, so the redesign misses the single shared box style requested in issue #802.
Findings
- [medium] The three stat boxes are internally inconsistent.
MarketCapBoxstill renderslabel -> value, while the new Supply and Deadline boxes rendervalue -> label, so the header ends up with mixed box layouts instead of one profile-style pattern.- File:
src/components/MarketCapBox.tsx:37 - File:
src/app/story/[storylineId]/page.tsx:347 - Suggestion: Normalize all three boxes to the same label/value structure rather than wrapping the old
MarketCapBoxunchanged while flipping the others.
- File:
Decision
Requesting changes until the three stat boxes use one consistent internal layout, which is the core design requirement of issue #802.
Flip MarketCapBox from label-then-value to value-then-label layout, matching the profile page stat box pattern (text-sm font-bold value on top, text-[9px] text-muted label below). All 3 stat boxes now render consistently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up change resolves my prior design blocker. MarketCapBox now uses the same value-on-top, label-below stat-box structure as the Supply and Deadline boxes, which matches the referenced profile-page pattern.
Findings
- [resolved] The three stat boxes now share one consistent internal layout.
- File:
src/components/MarketCapBox.tsx:36 - File:
src/app/story/[storylineId]/page.tsx:339 - Suggestion: None.
- File:
Decision
Approving. My prior blocker on mixed stat-box layouts is addressed.
2 participants
Summary
border-border rounded border px-2 py-1.5 text-centerwith value on top, label belowLayout
Test Plan
Fixes #802
🤖 Generated with Claude Code